Skip to content

Disable the message servlet by default#2000

Open
cshannon wants to merge 2 commits into
apache:mainfrom
cshannon:disable-message-servlet
Open

Disable the message servlet by default#2000
cshannon wants to merge 2 commits into
apache:mainfrom
cshannon:disable-message-servlet

Conversation

@cshannon
Copy link
Copy Markdown
Contributor

@cshannon cshannon commented May 11, 2026

The servlet will still be enabled by default in the web demo project

Edit: I marked the servlet as deprecated and also added comments about why

@jbertram
Copy link
Copy Markdown
Contributor

Does this mean that we're essentially dropping support for the REST messaging API?

@cshannon cshannon force-pushed the disable-message-servlet branch from ad8ac87 to 15d8d60 Compare May 11, 2026 15:18
@cshannon cshannon requested a review from mattrpav May 11, 2026 15:28
jbonofre
jbonofre previously approved these changes May 11, 2026

<display-name>Apache ActiveMQ REST API</display-name>

<servlet>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth to keep in the file, but commented, just in case the user absolutely wants to use it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally just commented it out but then removed it entirely (it's still the demo project). I can go either way though. @mattrpav what do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my original commit before force pushing: ad8ac87

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with comment it out as a good step here. It'll surface questions from users needing to reanble it and we'll get a sense of how it is used.

Going forward (v7) there is probably a modernization task for this.

@mattrpav
Copy link
Copy Markdown
Contributor

Does this mean that we're essentially dropping support for the REST messaging API?

No. This is a security stance of being more “locked down” by default. Administrators are then encouraged to enable features and service they need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants