fix: route Bedrock SSE error events to the error handler#1475
Open
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Open
fix: route Bedrock SSE error events to the error handler#1475xodn348 wants to merge 1 commit intoanthropics:mainfrom
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Conversation
…1472) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
karpetrosyan
reviewed
May 7, 2026
| data = json.loads(message) | ||
| if is_dict(data) and data.get("type") == "error": | ||
| return "error" | ||
| except (ValueError, KeyError): |
Collaborator
There was a problem hiding this comment.
when it raises ValueError or KeyError? I think the only error the code above can raise it's json.decoder.JSONDecodeError during json.loads(message)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1472
What
The Bedrock
AWSEventStreamDecoderpreviously hardcoded all SSE events asevent="completion", causing error payloads (e.g.rate_limit_error) from Bedrock to be deserialized asRawMessageStartEventwithmessage=Noneinstead of being routed to the existing error handler. This resulted inAttributeError: 'NoneType' object has no attribute 'model'crashes during streaming.This fix inspects the decoded event payload and emits
event="error"for events with"type": "error", allowing the existing error handling path inStream.__stream__()to raise a properAPIStatusError.Verification