fix: increase markdown bold weight and bound status popover scroll - #44097
Open
SomSamantray wants to merge 2 commits into
Open
fix: increase markdown bold weight and bound status popover scroll#44097SomSamantray wants to merge 2 commits into
SomSamantray wants to merge 2 commits into
Conversation
strong/b rendered at font-weight 500 in the new layout and with no weight override at all in the legacy layout, making bold text nearly indistinguishable from regular text. Closes anomalyco#43597
Neither Tabs instance in status-popover-body.tsx had a height constraint, so tabs.css's existing overflow-y: auto never had anything to scroll within — the popover just grew off-screen with many MCP/plugin entries. Closes anomalyco#43668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #43597
Closes #43668
Type of change
What does this PR do?
Two small, independent UI bugs bundled together since each is a one-line-ish fix in a different file:
**bold**rendered atfont-weight: 500in the new layout, and with no weight override at all in the legacy layout — both cases looked almost identical to regular text. Bothstrong/brules inmarkdown.cssnow usefont-weight: 700.tabs.cssalready has workingoverflow-y: autoscroll CSS, but nothing above it constrained a height, so with many entries the popover just grew unbounded. Addedmax-h-[60vh]to both<Tabs>instances instatus-popover-body.tsxso the existing scroll CSS actually activates.How did you verify your code works?
bun run typecheckpasses (packages/app, and the full monorepo pre-push typecheck).oxlinton both changed files shows the same pre-existing warnings as before the change (0 new warnings, 0 errors) — confirmed by diffing lint output against the base branch.tabs.css's[data-slot="tabs-content"] { overflow-y: auto }only needed a bounded ancestor height to activate, and thatmarkdown.cssis the single shared component both Desktop and Web UI render through.Screenshots / recordings
No response — no browser tooling available in the environment I used to prepare this PR. Happy to add screenshots if a maintainer can't easily verify visually.
Checklist