fix(kimi-for-coding): inherit attachment support for K3 models - #6102
Open
ysntony wants to merge 1 commit into
Open
fix(kimi-for-coding): inherit attachment support for K3 models#6102ysntony wants to merge 1 commit into
ysntony wants to merge 1 commit into
Conversation
Both k3 and k3-256k inherit from the moonshotai/kimi-k3 lab base, which already declares attachment = true, so per the repo's override-only rule the correct fix is to drop the stale attachment = false override rather than flip it. On the Kimi For Coding endpoint both models accept image input (k3 also accepts video), per Kimi Code's own subscription model catalog: k3 lists image_in and video_in, k3-256k lists image_in. The declared [modalities] already match this (k3 inherits text/image/video from the base; k3-256k declares text/image), so the inherited flag is now consistent with modalities — same class of fix as anomalyco#5793.
ysntony
force-pushed
the
fix/kimi-for-coding-k3-attachment
branch
from
September 3, 2026 04:02
09f2976 to
b8b0b7b
Compare
ysntony
changed the title
ysntony
marked this pull request as ready for review
September 3, 2026 04:09
Contributor
|
No actionable findings. |
github-actions
Bot
added
the
reviewer: ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops the stale
attachment = falseoverride fromk3.tomlandk3-256k.tomlunderproviders/kimi-for-coding/, letting the flag inherittruefrom themoonshotai/kimi-k3lab base (per the repo's override-only rule forbase_modelfiles).Why
Both models accept image input on the Kimi For Coding endpoint, and
k3also accepts video. This is reflected in Kimi Code's own subscription model catalog (the OAuth-managed provider in the Kimi Code CLI), which lists:k3:image_in,video_ink3-256k:image_in(no video)The TOML files already declare matching
[modalities]—k3inheritstext/image/videoinput from the lab base, andk3-256kdeclarestext/imagewith a header comment noting "accepts no video input (image only)". Theattachment = falseoverride contradicted those modalities and makes the models unusable for image attach flows in tools that gate on the flag.Same class of fix as #5793 (align attachment flag with modalities).
Validation
bun validatepasses.