fix(ExportDialogFragment.kt) : TransactionTooLargeException

[Alok-Silswal]

Purpose / Description

Export Dialog crashed when >60k browsed cards are selected and the user puts the app in the background.

Fixes

• Fixes Crash when reopening the app with certain dialogs in the browser and >60,000 cards selected #20509

Approach

Imitated the approach used in FindAndReplaceDialogFragment.kt to deal with this issue by using class IdsFile rather than using Bundle, which was overflowing when the capacity exceeded, thereby causing the crash.

How Has This Been Tested?

Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.

I reproduced the issue. It

• directed me to the main screen: when I waited for some time (maybe 10 seconds or so)
• showed error/crash: when I re-opened instantly

Both these observations have been tested. Video attached as evidence.

Learning (optional, can help others)

In ExportDialogFragment.kt, there is a scope for code refactoring and cleanup. This would have shrunk this PR by some lines. But I intentionally avioided it in this PR as it do not fit in this scope.

Export_dialog_app_reopen_issue_resolved.mp4

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[david-allison]

This doesn't handle the case where the IdsFile is deleted, so getIds() fails

[david-allison]

Don't copy/paste code, make an extension method

[Alok-Silswal]

I am not able to understand this.

[david-allison]

This code is copy/pasted from:

Anki-Android/AnkiDroid/src/main/java/com/ichi2/anki/browser/FindAndReplaceDialogFragment.kt

Lines 181 to 192 in 95dbbf1

	/** Attempt to delete the associated [IdsFile] and logs the result */
	private fun removeIdsFile() {
	runCatching { idsFile.delete() }
	.onFailure { throwable ->
	Timber.w(
	throwable,
	"Exception when removing IdsFile of FindAndReplaceDialogFragment",
	)
	}.onSuccess { status ->
	Timber.i("FindAndReplaceDialogFragment associated IdsFile was deleted: $status")
	}
	}

Instead, define idsFile.removeSafely(), either as a method on the class, or an extension method

fun IdsFile.removeSafely() {
   // code
}

[david-allison]

val ids = requireArguments().requireParcelable(ARG_IDS_FILE).getIds()