Disable Save button in Change Note Type when there are no changes#20968
Open
sanjaysargam wants to merge 1 commit intoankidroid:mainfrom
Open
Disable Save button in Change Note Type when there are no changes#20968sanjaysargam wants to merge 1 commit intoankidroid:mainfrom
sanjaysargam wants to merge 1 commit intoankidroid:mainfrom
Conversation
david-allison
requested changes
May 7, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
Thanks!
Please convert to a flow in the ViewModel
| onItemSelectedListener = | ||
| BasicItemSelectedListener { position, id: NoteTypeId -> | ||
| viewModel.setOutputNoteTypeId(id) | ||
| updateSaveButton(binding) |
Member
There was a problem hiding this comment.
architecture: This should react to an update, not be set in a listener
Comment on lines
+419
to
+422
| (requireParentFragment() as ChangeNoteTypeDialog) | ||
| .updateSaveButton( | ||
| DialogChangeNoteTypeBinding.bind(requireParentFragment().requireView()), | ||
| ) |
Member
There was a problem hiding this comment.
ditto: this line shouldn't update and the data should come from a flow in the ViewModel
| SelectedIndex.from(position) | ||
| } | ||
| viewModel.updateTemplateMapping(outputTemplateIndex = spinnerIndex, newMapping) | ||
| (requireParentFragment() as ChangeNoteTypeDialog) |
david-allison
added
the
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Currently in Change Note Type, clicking Save without making any changes shows a No changes to save dialog.
Approach
Instead of showing a dialog, Save button is now disabled when there are no pending changes.
How Has This Been Tested?
Emulator API 35
Checklist
Please, go through these checks before submitting the PR.