feat: Added support for instrumentForCoverage#1115
Merged
Conversation
26a3dc0 to
5e2b71a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Istanbul code coverage instrumentation in the application build and serve process, enabling code coverage collection for end-to-end (E2E) tests such as Cypress. The changes introduce new builder options for enabling instrumentation and specifying files to exclude from coverage, and implement the necessary logic to apply these options during the build.
Coverage Instrumentation Support:
schema.json:instrumentForCoverage(boolean flag to enable Istanbul coverage instrumentation) andcodeCoverageExclude(array of globs for files to exclude from coverage).coverage-instrumentation.tsthat provides helpers for resolving the instrumentation filter, determining excluded paths, and matching project source roots. This logic is adapted from Angular's internal code coverage support.Builder Logic Updates:
builder.tsto resolve and apply the instrumentation filter wheninstrumentForCoverageis enabled, ensuring only the intended files are instrumented for coverage. [1] [2]instrumentForCoveragefilter, integrating coverage instrumentation seamlessly into both build and serve workflows. [1] [2]Imports and Integration:
resolveInstrumentationFilterutility in the main builder file for use in the build process.