Repository navigation
Cold boot emulator CI and preserve failed device diagnostics - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.0.3 finalization correctly stopped when API 26 CI failed before instrumentation: both startup attempts restored the same snapshot and failed on the action’s input command with exit 137. In the fix PR, API 26 passed with cold boot, while API 35 repeatedly disconnected ADB during Logcat collection after two successful tests on a restored snapshot.
Cold boot both APIs with
-no-snapshotand remove AVD snapshot caching/generation. Keep KVM acceleration, the existing single startup retry, and the ban on test retries. Update English/Russian documentation and project memory.The API 35 failure also exposed stale successful JUnit output: failed diagnostics prevented report updates, then cleanup masked the cause. Preserve failed ADB output, record diagnostics failures in JUnit before aborting, and preserve the original error during disposable-emulator cleanup. Diagnostics failures still fail CI.
Validation:
actionlint .github/workflows/android-device.yml;bundle exec fastlane android python_checks(51 tests passed; pinned Python tools viaPYTHON), including a regression check for failed Logcat and cleanup. Full cold-boot CI passed: https://github.com/andre487/AndroidMegaProxy/actions/runs/37612472017 . Both API 26 and API 35 device jobs passed without the startup retry; native integration, Python, Android JVM/lint/build checks and result publishing also passed.Once merged, release PR #67 must be rebuilt on current main with its single release commit and full CI, then finalized using its new explicit head. The original finalization run is pinned to the old head/base.