fix: publish release images to ECR - #45
Open
zhukaihan wants to merge 1 commit into
Open
Conversation
zhukaihan
force-pushed
the
pz/evaluation-proxy-ecr-publish
branch
from
August 28, 2026 17:28
273b0e2 to
cd5573a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amplitude/deploy; the release workflow only references theevaluation-proxyrepository namePublishing flow
evaluation-proxyrelease → ops ECRevaluation-proxy→ platform ECR-to-DockerHub sync →amplitudeinc/evaluation-proxyThe repository is already declared by
createRepo: trueinamplitude/deploy. This PR does not duplicate that infrastructure definition or expose DockerHub credentials to the GitHub Actions runner.Validation
./gradlew ktlintCheck test.github/workflows/release.yamlas YAMLgit diff --checkPlatform dependencies
gha-evaluation-proxy-releasemust have push access to the ECR repositoryevaluation-proxyto DockerHubamplitudeinc/evaluation-proxyand preserve the semantic-version tagApplication runtime code is unchanged.
Note
Medium Risk
Changes the release pipeline's auth and image destination; a misconfigured OIDC role or ECR repo would block releases until fixed, but application runtime code is untouched.
Overview
Release workflow no longer logs into Docker Hub with a PAT. It now requests
id-token: write(andcontents: read) so the job can assume AWS credentials in the ops account, log into Amazon ECR, and push semver-taggedevaluation-proxyimages to the ECR registry from the login step.Docker image metadata and push use
${{ steps.login-ecr.outputs.registry }}/evaluation-proxyinstead ofDOCKERHUB_USERNAME/evaluation-proxy, and the build/push step switches to Amplitude'sconfigure-aws-credentials,amazon-ecr-login, andbuild-push-actionwrappers.Reviewed by Cursor Bugbot for commit cd5573a. Bugbot is set up for automated code reviews on this repo. Configure here.