Valgrind fixes and bridge commands consolidation#87
Open
sinuscosinustan wants to merge 4 commits into
Open
Conversation
The clangd LSP in Emacs configures itself to cache in the project by default. Signed-off-by: Tan Siewert <tan@siewert.io>
Fix the easy stuff that valgrind has found. Signed-off-by: Tan Siewert <tan@siewert.io>
Signed-off-by: Tan Siewert <tan@siewert.io>
With the existence of the `via` keyword, we do not need separate commands anymore for each bridge. The only exception in this case is the P2A bridge, as it has some code to allow the user to specify if they want to access the AHB bridge via the VGA, or the BMC device. Closes: #82 Signed-off-by: Tan Siewert <tan@siewert.io>
amboar
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's time again for a small batch of things I did during the train ride 😸
*make_root_doc), but the obvious ones which are justs/malloc/callocwere fixed ^^readandwritecommands. The functionality was almost always the same for each command. The only difference was in the initialisation, which we do not have to do like it was done before. However, the P2A command is an exception. There's some code that allows to define if a user wants to use the VGA, or the BMC PCIe device. An alternative implementation would be to have either an argument that only applies if the bridge inconnectionisp2a, or have two bridges calledp2a-vgaandp2a-bmc, but I do not necessarily see the benefit here.Closes #82