Conversation
Registers Amber::Pipe::SecureHeaders.new in the generated web pipeline before Amber::Pipe::Error. Placing SecureHeaders before Error ensures that unrouted (404) and error responses retain baseline security headers (such as X-Content-Type-Options: nosniff). Co-developed-by: Gemini AI <renich+gemini@woralelandia.com> Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
renich
force-pushed
the
security/register-secure-headers-pipe
branch
from
September 16, 2026 03:36
f64826f to
bb0a0f7
Compare
…lines Plug Amber::Pipe::SecureHeaders before Error pipe in active NewCommand generator heredoc as well as legacy routes.cr.ecr template. Include regression spec asserting presence in generated routes. Co-developed-by: Gemini AI <renich+gemini@woralelandia.com> Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
SecureHeaderspipe in the generated application route template (routes.cr.ecr) by default in the:webpipeline.This completes the registration of the
SecureHeaderspipe (which was added in the core framework inamberframework/amber#1390) so that newly generated apps will benefit from baseline security headers (XSS, Frame Options, nosniff, HSTS) out of the box.Co-developed-by: Gemini AI renich+gemini@woralelandia.com
Signed-off-by: Rénich Bon Ćirić renich@woralelandia.com