Skip to content

ux: add accessible labels to generated scaffold views #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ux: add accessible labels to generated scaffold views #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1596e2b
ux: add accessible labels to generated scaffold views
renich Jun 15, 2026
29cc7f3
ux(scaffold): associate labels and inputs with matching id and for at…
renich Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/amber_cli/commands/generate.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,21 +1547,21 @@ VIEW
if input_type == "textarea"
<<-FIELD
.form-group
label #{field_name.camelcase}
textarea name="#{field_name}" = @#{variable_name}.try(&.#{field_name})
label for="#{field_name}" #{field_name.camelcase}
textarea id="#{field_name}" name="#{field_name}" = @#{variable_name}.try(&.#{field_name})
FIELD
elsif input_type == "checkbox"
<<-FIELD
.form-group
label
input type="checkbox" name="#{field_name}" checked=@#{variable_name}.try(&.#{field_name})
label for="#{field_name}"
input id="#{field_name}" type="checkbox" name="#{field_name}" checked=@#{variable_name}.try(&.#{field_name})
| #{field_name.camelcase}
FIELD
else
<<-FIELD
.form-group
label #{field_name.camelcase}
input type="#{input_type}" name="#{field_name}" value=@#{variable_name}.try(&.#{field_name})
label for="#{field_name}" #{field_name.camelcase}
input id="#{field_name}" type="#{input_type}" name="#{field_name}" value=@#{variable_name}.try(&.#{field_name})
FIELD
end
end.join("\n")
Expand Down
2 changes: 2 additions & 0 deletions src/amber_cli/templates/scaffold/view/src/views/{{name}}/_form.ecr.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<div class="form-group">
<% case field.type
when "text" -%>
<%="<"%>%= label(<%=":#{field.name}"%>) -%>
<%="<"%>%= text_area(name: "<%= field.name -%>", content: <%= @name %>.<%= field.name %>, placeholder: "<%= field.name.capitalize %>", class: "form-control", size: "30x10") -%>
<% when "boolean" -%>
<%="<"%>%= label(<%=":#{field.name}"%>) do
Expand All @@ -27,6 +28,7 @@
<%="<"%>%= label(<%=":#{field.name}"%>) -%>
<%="<"%>%= select_field(name: "<%= field.name %>_id", collection: <% if config.model == "crecto" %>Repo.all(<%= field.class_name %>)<% else %><%= field.class_name %>.all<% end %>.map{|<%= field.name %>| [<%= field.name %>.id, <%= field.name %>.id]}, selected: <%= @name %>.<%= field.name %>_id, class: "form-control") -%>
<% else -%>
<%="<"%>%= label(<%=":#{field.name}"%>) -%>
<%="<"%>%= text_field(name: "<%= field.name %>", value: <%= @name %>.<%= field.name %>, placeholder: "<%= field.name.capitalize %>", class: "form-control") -%>
<% end -%>
</div>
Expand Down
2 changes: 2 additions & 0 deletions src/amber_cli/templates/scaffold/view/src/views/{{name}}/_form.slang.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
.form-group
<%- case field.type
when "text" -%>
== label(<%=":#{field.name}"%>)
== text_area(name: "<%= field.name -%>", content: <%= @name %>.<%= field.name %>, placeholder: "<%= field.name.capitalize %>", class: "form-control", size: "30x10")
<%- when "boolean" -%>
== label(<%=":#{field.name}"%>) do
Expand All @@ -17,6 +18,7 @@
== label(<%=":#{field.name}"%>)
== select_field(name: "<%= field.name %>_id", collection: <% if config.model == "crecto" %>Repo.all(<%= field.class_name %>)<% else %><%= field.class_name %>.all<% end %>.map{|<%= field.name %>| [<%= field.name %>.id, <%= field.name %>.id]}, selected: <%= @name %>.<%= field.name %>_id, class: "form-control")
<%- else -%>
== label(<%=":#{field.name}"%>)
== text_field(name: "<%= field.name %>", value: <%= @name %>.<%= field.name %>, placeholder: "<%= field.name.capitalize %>", class: "form-control")
<%- end -%>
<%- end -%>
Expand Down