Conversation
Author
|
Hello! I have updated the PR to remove the I apologize for the oversight regarding Co-developed-by: Gemini AI renich+gemini@woralelandia.com |
renich
changed the title
Phase 2:
- Refactored `Process.run` and `Process.new` calls in `helpers.cr` and
`process_runner.cr` to eliminate `shell: true` and use the RFC 0025 typed
Process API, preventing shell injections.
- Implemented LRU Cache boundaries on `@@cache` in `ai_transformer.cr`
with a `MAX_CACHE_SIZE` of 1000 to prevent memory leaks in persistent instances.
- Removed unused `shell: true` flag in `database.cr` seed invocation.
Phase 3:
- Applied `@[TargetFeature("+avx2")]` to the high-frequency string
parsing methods in `AmberCLI::Vendor::Inflector` to accelerate regex and
string operations.
Co-developed-by: Gemini AI <renich+gemini@woralelandia.com>
Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
Remove unnecessary and platform-unfriendly `@[TargetFeature("+avx2")]` annotations from inflector helper methods.
Co-developed-by: Gemini AI <renich+gemini@woralelandia.com>
Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
- Add Mutex synchronization to AITransformer.@@cache to prevent data races under M:N multithreading. - Guard Helpers.run against empty command strings. - Add optional shell parameter to Helpers.run and retain shell: true for user-defined tasks in Sentry watch runner. - Add concurrency spec for AITransformer cache. Co-developed-by: Gemini AI <renich+gemini@woralelandia.com> Signed-off-by: Rénich Bon Ćirić <renich@woralelandia.com>
renich
force-pushed
the
feature/modernize-process-simd
branch
from
September 16, 2026 07:51
70f8298 to
506c9e5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: modernize Process API calls and eliminate shell injection
Process.runandProcess.newcalls inhelpers.crandprocess_runner.crto eliminateshell: trueand use the RFC 0025 typed Process API, preventing shell command injections.@@cacheinai_transformer.crwith aMAX_CACHE_SIZEof 1000 to prevent memory leaks in persistent instances.shell: trueflag indatabase.crseed invocation.@[TargetFeature("+avx2")]annotations following upstream review ongranite#514.Co-developed-by: Gemini AI renich+gemini@woralelandia.com
Signed-off-by: Rénich Bon Ćirić renich@woralelandia.com