Skip to content

Keep overlay visible while transcribing - #793

Open
so1omon563 wants to merge 1 commit into
altic-dev:mainfrom
so1omon563:codex/issue-676-overlay-processing
Open

Keep overlay visible while transcribing#793
so1omon563 wants to merge 1 commit into
altic-dev:mainfrom
so1omon563:codex/issue-676-overlay-processing

Conversation

@so1omon563

@so1omon563 so1omon563 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Keep the normal dictation overlay visible in its existing “Transcribing” state until final transcription finishes, then hide it through the shared post-output lifecycle.

The regression came from a normal-dictation-only branch that requested an asynchronous overlay hide before asr.stop() began. Removing that special case lets normal dictation use the same processing lifecycle already used by AI, Command, Rewrite, prompt-test, and sandbox routes.

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

Closes #676.

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26.5.2
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources (SwiftLint is not installed locally)
  • Ran formatter locally: swiftformat --config .swiftformat Sources (SwiftFormat is not installed locally)
  • Ran tests locally: xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'

Also verified with swiftc -parse, git diff --check, an unsigned app build, and a real normal-dictation stop cycle. Runtime benchmarks confirmed processing=true before asr.stop(), the overlay remained visible while final transcription ran, and hide began only after asr.stop() returned.

Screenshots / Video

Before: reporter’s screen recording showing the overlay disappearing before transcription completes.

After: normal dictation keeps the overlay active through final processing and completes in the Test Playground. The final three seconds are a still of the completed result for readability.

  • No UI/visual changes; screenshots/video are not applicable.

Notes

This removes 19 net lines and adds no new state or abstraction.

AI assistance: Codex was used for implementation and validation.

@so1omon563
so1omon563 marked this pull request as ready for review August 5, 2026 17:29
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR keeps the dictation overlay in its “Transcribing” state until final recognition completes, then delegates dismissal to the shared post-output lifecycle.

  • Removes the normal-dictation-specific early overlay hide.
  • Uses the existing processing and output-completion paths for overlay dismissal.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (4): Last reviewed commit: "Keep overlay visible while transcribing" | Re-trigger Greptile

@altic-dev

Copy link
Copy Markdown
Owner

Hi is there a after video? I see the before video! Thank you! seems like a nice PR!

@github-actions

Copy link
Copy Markdown

This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the keep-open or pinned label to prevent automatic closure.

@github-actions github-actions Bot added the stale label Aug 11, 2026
@so1omon563

Copy link
Copy Markdown
Contributor Author

Thanks! Here’s the after video:

FluidVoice-PR-793-after.mp4

This was captured against commit 161422b. It shows normal dictation keeping the notch overlay active through final processing, followed by the completed transcription in the Test Playground. The final three seconds are a still of the completed result so it remains readable.

@github-actions github-actions Bot removed the stale label Aug 12, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the keep-open or pinned label to prevent automatic closure.

@github-actions github-actions Bot added the stale label Aug 18, 2026
@so1omon563
so1omon563 force-pushed the codex/issue-676-overlay-processing branch from 161422b to fa0b6c3 Compare August 19, 2026 17:19
@github-actions github-actions Bot removed the stale label Aug 20, 2026
@so1omon563
so1omon563 force-pushed the codex/issue-676-overlay-processing branch from fa0b6c3 to 0385a96 Compare August 21, 2026 19:01
@so1omon563

Copy link
Copy Markdown
Contributor Author

Rebased onto current main and resolved the conflict while preserving the new Spoken Send path. Local validation and all PR checks pass. Ready for review when you have time.

@github-actions

Copy link
Copy Markdown

This pull request has been marked stale because it has had no activity for 5 days. It will be closed in 2 days if there is no further activity. Add the keep-open or pinned label to prevent automatic closure.

@github-actions github-actions Bot added the stale label Aug 27, 2026
@github-actions

Copy link
Copy Markdown

Closing this pull request because it remained inactive for 2 days after being marked stale.

@github-actions github-actions Bot closed this Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

This was closed automatically while waiting for review. Issue #676 is still open, and the fix remains applicable to current main. Could this PR be reopened when you have a chance?

@altic-dev altic-dev reopened this Aug 30, 2026
@altic-dev

Copy link
Copy Markdown
Owner

@so1omon563 Can you please take a look at the video you attached for after and tell me if that is what is intended ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Normal dictation overlay hides before transcription and text insertion complete

2 participants