Repository navigation
add DummyAlertAggregator and change test_basic_pipelines. - #323
Merged
Merged
Conversation
ernstleierzopf
marked this pull request as ready for review
October 2, 2026 20:37
ipmach
requested changes
Oct 5, 2026
ipmach
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Fixes #172
Description
assert (result := alert_aggregator.process(data)) is not Noneproduce the unintended side effect of callingalert_aggregator.process(data)twice. This is not intended and I changed all occurrences I found in the tests. (tested by setting log level to DEBUG). - see Walrus expression duplicate evaluation failures with rewrite pytest-dev/pytest#14445How Has This Been Tested?
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.