Skip to content

add DummyAlertAggregator and change test_basic_pipelines. - #323

Merged
ipmach merged 11 commits into
mainfrom
feature/alert-aggregation-output-schema
Oct 5, 2026
Merged

ipmach merged 11 commits into
mainfrom
feature/alert-aggregation-output-schema

Conversation

@ernstleierzopf

@ernstleierzopf ernstleierzopf commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Task

Fixes #172

Description

  • add DummyAlertAggregator
  • add DummyAlertAggregator to test_basic_pipelines.py
  • finding: lines such as assert (result := alert_aggregator.process(data)) is not None produce the unintended side effect of calling alert_aggregator.process(data) twice. This is not intended and I changed all occurrences I found in the tests. (tested by setting log level to DEBUG). - see Walrus expression duplicate evaluation failures with rewrite pytest-dev/pytest#14445

How Has This Been Tested?

Checklist

  • This Pull-Request goes to the development branch.
  • I have successfully run prek locally.
  • I have added tests to cover my changes.
  • I have linked the issue-id to the task-description.
  • I have performed a self-review of my own code.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Base automatically changed from development to main September 30, 2026 07:24
@ernstleierzopf
ernstleierzopf marked this pull request as ready for review October 2, 2026 20:37
@ernstleierzopf
ernstleierzopf requested a review from ipmach October 2, 2026 20:51
Comment thread tests/test_workspace/test_create_workspace.py
@ipmach
ipmach merged commit 27402da into main Oct 5, 2026
3 checks passed
@ipmach
ipmach deleted the feature/alert-aggregation-output-schema branch October 5, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing alert aggregation in mate command

2 participants