diagnostics: close-forensics Drop timing + skip_vector_index_restore - #2
Open
jarmen423 wants to merge 3 commits into
Open
diagnostics: close-forensics Drop timing + skip_vector_index_restore#2jarmen423 wants to merge 3 commits into
jarmen423 wants to merge 3 commits into
Conversation
Add a feature-gated non-owning event ring and tiny Drop/worker events for GrafeoDB, BufferManager, HnswIndex, and checkpoint timer so staging can prove engine teardown without retaining diagnosed Arcs.
Attribute free/close work inside timed Drop regions (emit phases after work), keep checkpoint JOINED after join, and expose DROP_ENTER/DROP_PHASE event codes for sidecar close breakdowns.
Allow Config.skip_vector_index_restore to omit VectorStore HNSW topology deserialize and quantized rehydrate so staging can measure lexical-only RSS.
This was referenced Jul 29, 2026
jarmen423
added a commit
that referenced
this pull request
Aug 2, 2026
Replace the parity test's runtime oracle regeneration with committed binary golden fixtures. D0.8.10 #2 forbids regenerating the eager reference at test time. - Add tests/golden/gem0_5b/parity_dense.v5 (1844 bytes, frozen at SHA ca0d606 — the last D0.8.7 commit where the eager path is the source of truth). - Parity test now loads the golden fixture via golden_fixture() and compares against the bounded output, instead of calling eager_lexicographic_payload at test time. - Add write_golden_fixtures test (#[ignore]) for one-time fixture generation: run manually, commit output. The eager_lexicographic_payload helper remains for the diag tests and the fixture generator, but is NOT called from the acceptance parity test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnostics-only Grafeo changes for sidecar close forensics.
Companion AM PR: https://github.com/jarmen423/agent-memory-hosted/pull/63
close-forensicslifecycle sink + DROP_ENTER/PHASE timingConfig.skip_vector_index_restorefor lexical-only open RSS experimentsBase:
agent/txn-session-batch-20260726(9781320f— current AM product Grafeo pin).PR diff is 12 files / 3 commits only (excludes the large W1/batch/vector stack already on that pin).
Head SHA:
5a82b49d08de769bfc19a0f22baece25e90b6b74Scope / non-goals
Test plan
close-forensicsskip_vector_index_restoreopen path used only under diagnostics env