Archive compilation core dumps on compile failure

[mahdipub]

When a JVM crash occurs during test compilation (e.g. an AOT relocation crash as seen in eclipse-openj9/openj9#24627), moveDmp.pl moves dump files to output_compilation/ then calls false to abort make. This causes the Jenkins shell step in makeCompileTest() to throw before env.jobStatus is updated from its initial SUCCESS value, so the FAILURE branch in post() is never reached and the dumps are wiped by cleanWs.

Wrap the compile sh step in a try/catch: archive *.dmp and *.trc from output_compilation/ in the catch block, then re-throw so the build still fails as expected.

Fixes: eclipse-openj9/openj9#24627

Signed-off-by: mahdi@ibm.com

[annaibm]

LGTM

[annaibm]

One other thing : -
Since this crash is intermittent (needed 50 grinder iterations to reproduce), have you run the patched Jenkinsfile against a repro — either Kavin's grinder job or a forced failure — and confirmed the .dmp/.trc files actually show up as archived artifacts on the build page, not just that the build failed as expected?

[mahdipub]

One other thing : - Since this crash is intermittent (needed 50 grinder iterations to reproduce), have you run the patched Jenkinsfile against a repro — either Kavin's grinder job or a forced failure — and confirmed the .dmp/.trc files actually show up as archived artifacts on the build page, not just that the build failed as expected?

No I didn't. But I will ask in issue to see if they can test it on my fork and force a failure to prove it work.

[KavinSatheeskumar]

@annaibm @mahdipub
Here is that test you wanted
https://openj9-jenkins.osuosl.org/job/Grinder/5388/

[annaibm]

@pshipton Kindly review

[mahdipub]

@pshipton could you please review again?