fix(renovate): track ghcr.io/adobe/koperator/kafka -jdk<version> tags - #317
Merged
Merged
Conversation
The 3.9.2 Kafka image was published as 2.13-3.9.2-jdk21.0.11 instead of the plain 2.13-3.9.2 shape prior releases used, so the packageRule's matchCurrentValue/versioning regex (scoped to the plain shape only) couldn't see it as a valid version. Renovate silently had nothing to bump, and PR #302 shipped with DefaultKafkaImage still on 3.9.1. Extend the versioning regex to parse an optional -jdk<major>.<interim>.<update> suffix, mapping jdk major/update onto the regex versioning module's build/revision slots so both tag shapes compare correctly against each other. This does not gate jdk-major jumps the way 'compatibility' gates the scala prefix - that's deferred to the same operator-side migration already planned for the apache/kafka 4.x bump. Since this changes which tags are valid for the ghcr.io image line, manually cut over the two DefaultKafkaImage/defaultKafkaImage constants to the now-current 2.13-3.9.2-jdk21.0.11 tag; Renovate will track further -jdk<version> bumps automatically going forward. The ~20 config/samples/**/docs/benchmarks/** references still pinned to 3.9.1 are left for Renovate's own follow-up PR (same customManager/packageRule now covers them) rather than hand-edited here to avoid conflicting with that automated PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.13-3.9.2-jdk21.0.11instead of the plain2.13-3.9.2shape prior releases used, so theghcr.io/adobe/koperator/kafkapackageRule'smatchCurrentValue/versioning regex (scoped to the plain shape only) couldn't see it as a valid version. Renovate silently had nothing to bump, and chore(deps): update all non-major dependencies (master) #302 shipped withDefaultKafkaImagestill on 3.9.1.-jdk<major>.<interim>.<update>suffix, mapping jdk major/update onto the regex-versioning module'sbuild/revisionslots so both tag shapes compare correctly. This does not gate jdk-major jumps (e.g. jdk21.x -> jdk25.x) the waycompatibilitygates the scala prefix - that's deferred to the same operator-side migration already planned for the apache/kafka 4.x bump (seedocker/kafka/Dockerfile'sjava_versioncomment).DefaultKafkaImage/defaultKafkaImageto the now-current2.13-3.9.2-jdk21.0.11tag; Renovate will track further-jdk<version>bumps automatically going forward. The remainingconfig/samples/**/docs/benchmarks/**references still pinned to 3.9.1 are left for Renovate's own follow-up PR (same customManager/packageRule now covers them) rather than hand-edited here.Test plan
renovate-config-validatorpasses against the updatedrenovate.jsonrenovate --platform=local --dry-run=fullagainst the live registry confirmscurrentValue: "2.13-3.9.1"->newValue: "2.13-3.9.2-jdk21.0.11",updateType: "patch", with zero warnings/errors, across every annotated occurrencego build ./...andgo vet ./...pass in both the root module and theapi/submodulego test ./api/v1beta1/...passes2.13-3.9.1string literals incontrollers/**/*_test.goare independent fixture pins (not references to the changed constants), so they're unaffected🤖 Generated with Claude Code