Conversation
Cleanup job consistently timed out because listOldTestResources listed every page before any deletes ran, all inside the default 30s test timeout. It's now an async generator that yields items as pages are fetched, so deletes overlap with listing; test timeout raised to 5min and retries scoped down to 1 for this test. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
shsteimer
commented
Aug 31, 2026
| // only execute this test on chromium | ||
| return; | ||
| } | ||
| test.setTimeout(5 * 60 * 1000); |
Contributor
Author
There was a problem hiding this comment.
not sure this is really needed with other change, but also not sure it hurts anything. It should give any long action a bit more breathing room to finish the cleanup, and should be safe since the gh action already has a 30 min timeout, it was just individual test timeout of 30s causing the failures.
shsteimer
commented
Aug 31, 2026
| "test:all": "playwright test --project=chromium --project=firefox --project=webkit --grep-invert \"Delete multiple old pages\"", | ||
| "test:nonauth": "SKIP_AUTH=true playwright test --project=chromium tests/*.spec.js --grep-invert \"Delete multiple old pages\"", | ||
| "test:cleanup": "playwright test --project=chromium tests/delete.spec.js --grep \"Delete multiple old pages\"", | ||
| "test:cleanup": "playwright test --project=chromium tests/delete.spec.js --grep \"Delete multiple old pages\" --retries=1", |
Contributor
Author
There was a problem hiding this comment.
when they did fail, retries also failed on the pre-conditions, hence reducing to not retry since that will always fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup job consistently timed out because listOldTestResources listed every page before any deletes ran, all inside the default 30s test timeout. It's now an async generator that yields items as pages are fetched, so deletes overlap with listing; test timeout raised to 5min and retries scoped down to 1 for this test.
Description
noticed this job was consistently failing and backlog was growing
Related Issue
Motivation and Context
also seems like this may impact the frequent and consistent failures with PR playright tests timing out. cautiously hoping this better cleanup will help with that.
How Has This Been Tested?
ran https://github.com/adobe/da-live/actions/runs/33434325504 which deleted many files.
Screenshots (if appropriate):
Types of changes
Checklist: