Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
| _onEditorSelectState({ blockIndex, source }) { | ||
| if (source === 'doc') return; | ||
| this._scrollDocToBlock(blockIndex); | ||
| this._broadcastSelectedNode(true); |
Contributor
There was a problem hiding this comment.
Since this could be coming from an extension, maybe we could validate the blockindex prior to doing the broadcast?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ew-page-outlinepanel already does.scrollToaction to the existing extensionMessageChannelprotocol (blocks/canvas/ew-panel-extensions/iframe-protocol.js), relaying onto the existingcanvasBus.editorSelectState/editorProseSelectStatechannels — no new event mechanism.resolveSectionTargethelper ineditor-utils.js.ew-editor-doc.js's WYSIWYG-sync broadcast from "outline-sourced only" to "any non-doc source", so extension-triggered jumps also sync the WYSIWYG overlay.actions.scrollTo(target)SDK entry point extensions call) — both sides are additive and inert alone; neither breaks anything shipped independently.Test:
Test plan
resolveSectionTarget(block target, content target, empty section, out-of-range, cache-clear)scrollTohandler iniframe-protocol.js(block, content, section-resolved-to-block, out-of-range section, unrecognized type)ew-editor-doc.js's_onEditorSelectState(doc/outline/extension sources)🤖 Generated with Claude Code