feat(2868): ParseDBType supports GaussDB/openGauss aliases#620
Closed
actiontech-bot wants to merge 2 commits into
Closed
feat(2868): ParseDBType supports GaussDB/openGauss aliases#620actiontech-bot wants to merge 2 commits into
actiontech-bot wants to merge 2 commits into
Conversation
- 在原有 case "GaussDB for MySQL" 基础上扩展为四字面量并列匹配: "GaussDB" / "openGauss" / "GaussDB / openGauss" / "GaussDB for MySQL" 均映射到 DBTypeGaussDB - 字面量严格大小写敏感,未引入 ToLower/ToUpper 归一化 (与 design.md §3.3 / §3.8 一致;db_conn_ee.go switch 走 ToUpper 是另一套规则) - 新增 TestParseDBType_GaussDB_Aliases 正反双向覆盖 - 涉及 compat-RISK-1(决策 B:保留 ADR-004 历史命名兼容) Fixes actiontech/sqle-ee#2868
…pplied in code review after dms-ee validation This revert removes: - 67d9c80 feat(dms-ee): ParseDBType 支持 GaussDB/openGauss 4 种字符串别名 Reason: The new fix strategy keeps all GaussDB / openGauss data export logic in dms-ee only. The CE-side ParseDBType alias mirror will be re-introduced by the code_review stage once the dms-ee implementation is validated. Decision: User instruction in fix_session_20260520_073030 (see docs/dev/last_fix_issues.md): > "当前实现有误,回退所有代码变更。该需求应该只需要修改dms-ee代码..." Fixes actiontech/sqle-ee#2868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: actiontech/sqle-ee#2868 — 数据导出功能支持 GaussDB/openGauss 数据源。
DMS 侧
internal/dms/pkg/constant/const.goParseDBType新增 4 个 GaussDB 系列字符串别名 (compat-RISK-1 决策 B):GaussDB/openGauss/GaussDB / openGauss(新增三种 UI/常量字符串)GaussDB for MySQL(ADR-004 历史命名,回归保留)4 个字符串全部映射到
DBTypeGaussDB。字面量敏感匹配,无 ToLower/ToUpper 归一化。Tests
TestParseDBType_GaussDB_Aliases覆盖 4 个正向别名 + 5 个反向 case(大小写差异、空格差异等)db_conn_ee.goswitch case 中的字面量字符串保持一致Fixes actiontech/sqle-ee#2868