improve: add Tron variants for SpokePoolPeriphery and SwapProxy - #1502
improve: add Tron variants for SpokePoolPeriphery and SwapProxy#1502tbwebb22 wants to merge 3 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5ba27e5b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // Deploy the swap proxy with reference to the permit2 address | ||
| swapProxy = new SwapProxy(address(_permit2)); | ||
| swapProxy = _deploySwapProxy(address(_permit2)); |
There was a problem hiding this comment.
When Tron_SpokePoolPeriphery is constructed, this call occurs inside the SpokePoolPeriphery constructor, where Solidity resolves virtual calls to the implementation defined by the contract currently being constructed rather than the derived override. Consequently _deploySwapProxy creates a regular SwapProxy, so swaps where Tron USDT is transferred from the proxy to the exchange or back to the periphery still revert on its false return value, defeating the purpose of the Tron variant.
Useful? React with 👍 / 👎.
tbwebb22
changed the title
…Token Transfers (#1505) * address audit finding with comment updates * refine comments
2 participants
No description provided.