Fix Java map code generation#267
Open
Aayush10016 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Aayush Tiwari <aayushtiwari1001@gmail.com>
Aayush10016
marked this pull request as ready for review
July 17, 2026 15:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes generated Java for Concerto map declarations that use scalar aliases or imported map member types.
The Java visitor now:
Map<K, V>consistently for map fields, getters, and settersSSN->Stringhr_integrationJava compile verification case that was previously skipped for this bugValidation
npm.cmd cinpm.cmd run mocha -- test/codegen/fromcto/java/javavisitor.jsnpm.cmd run test:verify -- --grep "generated Java"npm.cmd run mocha -- test/codegen/codegen.jsnpm.cmd run test:verifynpm.cmd run lintnpm.cmd test -- --grep JavaVisitorwas also attempted, but the repository's global coverage gate still runs for filtered tests, so the focusedmochacommand above is the valid JavaVisitor test signal.Fixes #265.