Add price snapshot writer tests for unchanged prices - #855
Open
Akinsuyiphilip wants to merge 2 commits into
Open
Add price snapshot writer tests for unchanged prices#855Akinsuyiphilip wants to merge 2 commits into
Akinsuyiphilip wants to merge 2 commits into
Conversation
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@Akinsuyiphilip Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nCloses #763\n\nAdds unit coverage for the price snapshot writer's storage-saving behavior:\n\n- Verifies an unchanged price skips both the snapshot update and price-history insert.\n- Verifies a changed price updates the snapshot and creates a history record.\n- Verifies the first snapshot for a creator is always written.\n\n## Verification\n\n- — 7 tests passed.\n- src/config.schema.ts(273,7): error TS1117: An object literal cannot have multiple properties with the same name.
src/modules/admin/admin.routes.ts(30,10): error TS2305: Module '"@prisma/client"' has no exported member 'Prisma'.
src/modules/admin/admin.routes.ts(56,37): error TS2339: Property 'UNPROCESSABLE_ENTITY' does not exist on type '{ readonly VALIDATION_ERROR: "VALIDATION_ERROR"; readonly NOT_FOUND: "NOT_FOUND"; readonly UNAUTHORIZED: "UNAUTHORIZED"; readonly FORBIDDEN: "FORBIDDEN"; readonly CONFLICT: "CONFLICT"; ... 6 more ...; readonly NOT_A_CREATOR: "not_a_creator"; }'.
src/modules/admin/admin.routes.ts(61,37): error TS2339: Property 'UNPROCESSABLE_ENTITY' does not exist on type '{ readonly VALIDATION_ERROR: "VALIDATION_ERROR"; readonly NOT_FOUND: "NOT_FOUND"; readonly UNAUTHORIZED: "UNAUTHORIZED"; readonly FORBIDDEN: "FORBIDDEN"; readonly CONFLICT: "CONFLICT"; ... 6 more ...; readonly NOT_A_CREATOR: "not_a_creator"; }'.
src/modules/admin/admin.routes.ts(66,37): error TS2339: Property 'UNPROCESSABLE_ENTITY' does not exist on type '{ readonly VALIDATION_ERROR: "VALIDATION_ERROR"; readonly NOT_FOUND: "NOT_FOUND"; readonly UNAUTHORIZED: "UNAUTHORIZED"; readonly FORBIDDEN: "FORBIDDEN"; readonly CONFLICT: "CONFLICT"; ... 6 more ...; readonly NOT_A_CREATOR: "not_a_creator"; }'.
src/modules/admin/admin.routes.ts(105,37): error TS2339: Property 'UNPROCESSABLE_ENTITY' does not exist on type '{ readonly VALIDATION_ERROR: "VALIDATION_ERROR"; readonly NOT_FOUND: "NOT_FOUND"; readonly UNAUTHORIZED: "UNAUTHORIZED"; readonly FORBIDDEN: "FORBIDDEN"; readonly CONFLICT: "CONFLICT"; ... 6 more ...; readonly NOT_A_CREATOR: "not_a_creator"; }'.
src/modules/admin/admin.routes.ts(110,37): error TS2339: Property 'UNPROCESSABLE_ENTITY' does not exist on type '{ readonly VALIDATION_ERROR: "VALIDATION_ERROR"; readonly NOT_FOUND: "NOT_FOUND"; readonly UNAUTHORIZED: "UNAUTHORIZED"; readonly FORBIDDEN: "FORBIDDEN"; readonly CONFLICT: "CONFLICT"; ... 6 more ...; readonly NOT_A_CREATOR: "not_a_creator"; }'.
src/modules/admin/admin.routes.ts(366,27): error TS7006: Parameter 'p' implicitly has an 'any' type.
src/modules/admin/audit-log.integration.test.ts(71,30): error TS7006: Parameter 'e' implicitly has an 'any' type.
src/modules/admin/audit-log.integration.test.ts(245,43): error TS7006: Parameter 'e' implicitly has an 'any' type.
src/modules/admin/key-sync.service.ts(248,40): error TS7006: Parameter 'tx' implicitly has an 'any' type.
src/modules/creator/creator.routes.ts(73,23): error TS2339: Property 'UNPROCESSABLE_ENTITY' does not exist on type '{ readonly VALIDATION_ERROR: "VALIDATION_ERROR"; readonly NOT_FOUND: "NOT_FOUND"; readonly UNAUTHORIZED: "UNAUTHORIZED"; readonly FORBIDDEN: "FORBIDDEN"; readonly CONFLICT: "CONFLICT"; ... 6 more ...; readonly NOT_A_CREATOR: "not_a_creator"; }'.
src/modules/creator/creator.utils.ts(2,10): error TS2305: Module '"@prisma/client"' has no exported member 'Prisma'.
src/modules/creator/follow.service.ts(44,52): error TS7006: Parameter 'tx' implicitly has an 'any' type.
src/modules/creator/follow.service.ts(96,52): error TS7006: Parameter 'tx' implicitly has an 'any' type.
src/modules/creator/post.controller.ts(77,17): error TS7006: Parameter 'post' implicitly has an 'any' type.
src/modules/creators/creator-holders.service.ts(1,10): error TS2305: Module '"@prisma/client"' has no exported member 'Prisma'.
src/modules/creators/creator-holders.service.ts(87,46): error TS7006: Parameter 'row' implicitly has an 'any' type.
src/modules/creators/creator-holders.service.ts(87,51): error TS7006: Parameter 'index' implicitly has an 'any' type.
src/modules/creators/creator-holders.service.ts(224,46): error TS7006: Parameter 'row' implicitly has an 'any' type.
src/modules/creators/creator-holders.service.ts(224,51): error TS7006: Parameter 'index' implicitly has an 'any' type.
src/modules/creators/creator-leaderboard-volume.service.ts(121,34): error TS7006: Parameter 'creator' implicitly has an 'any' type.
src/modules/creators/creator-leaderboard-volume.service.ts(137,19): error TS7006: Parameter 'a' implicitly has an 'any' type.
src/modules/creators/creator-leaderboard-volume.service.ts(137,22): error TS7006: Parameter 'b' implicitly has an 'any' type.
src/modules/creators/creator-leaderboard-volume.service.ts(144,53): error TS7006: Parameter 'entry' implicitly has an 'any' type.
src/modules/creators/creator-leaderboard-volume.service.ts(144,60): error TS7006: Parameter 'index' implicitly has an 'any' type.
src/modules/creators/creators.controllers.ts(251,29): error TS7006: Parameter 'creator' implicitly has an 'any' type.
src/modules/creators/creators.controllers.ts(273,21): error TS7006: Parameter 'a' implicitly has an 'any' type.
src/modules/creators/creators.controllers.ts(273,24): error TS7006: Parameter 'b' implicitly has an 'any' type.
src/modules/creators/creators.controllers.ts(288,59): error TS7006: Parameter 'entry' implicitly has an 'any' type.
src/modules/creators/creators.controllers.ts(288,66): error TS7006: Parameter 'index' implicitly has an 'any' type.
src/modules/creators/creators.controllers.ts(397,29): error TS7006: Parameter 'creator' implicitly has an 'any' type.
src/modules/creators/creators.sort.ts(1,10): error TS2305: Module '"@prisma/client"' has no exported member 'Prisma'.
src/modules/creators/creators.utils.ts(1,10): error TS2305: Module '"@prisma/client"' has no exported member 'Prisma'.
src/modules/dividends/dividend.integration.test.ts(113,26): error TS7006: Parameter 'claim' implicitly has an 'any' type.
src/modules/dividends/dividend.service.ts(66,64): error TS7006: Parameter 'dist' implicitly has an 'any' type.
src/modules/dividends/dividend.service.ts(125,57): error TS7006: Parameter 'claim' implicitly has an 'any' type.
src/modules/dividends/dividend.service.ts(251,28): error TS7006: Parameter 'h' implicitly has an 'any' type.
src/modules/dividends/dividend.service.ts(260,28): error TS7006: Parameter 'h' implicitly has an 'any' type.
src/modules/indexer/dividend-indexer.service.ts(119,37): error TS7006: Parameter 'holder' implicitly has an 'any' type.
src/modules/indexer/indexer-resume.integration.test.ts(104,25): error TS7006: Parameter 'c' implicitly has an 'any' type.
src/modules/indexer/ledger-checkpoint.service.ts(168,40): error TS7006: Parameter 'sum' implicitly has an 'any' type.
src/modules/indexer/ledger-checkpoint.service.ts(168,45): error TS7006: Parameter 'r' implicitly has an 'any' type.
src/modules/indexer/persist-circulating-supply.service.ts(13,42): error TS7006: Parameter 'transaction' implicitly has an 'any' type.
src/modules/indexer/persist-circulating-supply.service.ts(18,47): error TS7006: Parameter 'total' implicitly has an 'any' type.
src/modules/indexer/persist-circulating-supply.service.ts(18,54): error TS7006: Parameter 'activity' implicitly has an 'any' type.
src/modules/keys/key-proposals.service.ts(49,25): error TS7006: Parameter 'p' implicitly has an 'any' type.
src/modules/users/referrals.service.ts(108,19): error TS7006: Parameter 'row' implicitly has an 'any' type.
src/modules/users/referrals.service.ts(109,22): error TS7006: Parameter 'id' implicitly has an 'any' type.
src/modules/users/referrals.service.ts(130,53): error TS7006: Parameter 'row' implicitly has an 'any' type.
src/modules/wallets/wallet-following.service.ts(22,36): error TS7006: Parameter 'f' implicitly has an 'any' type.
src/modules/wallets/wallet-following.service.ts(35,19): error TS7006: Parameter 'a' implicitly has an 'any' type.
src/modules/wallets/wallet-following.service.ts(35,22): error TS7006: Parameter 'b' implicitly has an 'any' type.
src/modules/wallets/wallet-holdings-pagination.integration.test.ts(37,33): error TS7006: Parameter 'c' implicitly has an 'any' type.
src/modules/webhooks/horizon-webhook.routes.ts(45,39): error TS7006: Parameter 'transaction' implicitly has an 'any' type.
src/modules/webhooks/webhook.service.ts(73,25): error TS7006: Parameter 'w' implicitly has an 'any' type.
src/types/wallet.types.ts(1,10): error TS2305: Module '"@prisma/client"' has no exported member 'StellarWallet'.
src/types/wallet.types.ts(1,25): error TS2305: Module '"@prisma/client"' has no exported member 'User'.
src/utils/creator-batch.utils.ts(34,20): error TS7006: Parameter 'r' implicitly has an 'any' type.
src/utils/price-change.utils.test.ts(4,15): error TS2305: Module '"@prisma/client"' has no exported member 'PrismaClient'.
src/utils/prisma.utils.ts(1,10): error TS2305: Module '"@prisma/client"' has no exported member 'PrismaClient'.
src/utils/prisma.utils.ts(83,24): error TS7031: Binding element 'operation' implicitly has an 'any' type.
src/utils/prisma.utils.ts(83,35): error TS7031: Binding element 'model' implicitly has an 'any' type.
src/utils/prisma.utils.ts(83,42): error TS7031: Binding element 'args' implicitly has an 'any' type.
src/utils/prisma.utils.ts(83,48): error TS7031: Binding element 'query' implicitly has an 'any' type. — currently reports existing repository errors, including duplicate config properties and unavailable generated Prisma exports.