Add quorum progress bar to proposal cards - #833
Open
Neziahtech wants to merge 6 commits into
Open
Conversation
|
@Neziahtech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…quorum-indicato-cd8dbrv0
- Change ConnectWalletButton popover label from "Connected Wallet" to "Wallet address" to match test assertions - Change minimumFractionDigits from 2 to 0 in formatDisplayKeyPrice so whole-number XLM values display as "65 XLM" not "65.00 XLM", matching the portfolioValue test expectations 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
The admin block was incorrectly nested inside governance, causing
a parse error (',' expected at line 51) because governance was
never properly closed before admin started. Made admin a sibling
key of governance at the queryKeys top level.
🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
- routes.tsx: Split governance route from admin route to fix duplicate property error (TS1117), added AdminDashboardPage import - course.service.ts: Add optional co-creator fields to Course type (coCreatorAddress, coCreatorSplitBps, totalPaidToCoCreator, totalPaidToCreator) to fix TS2339 errors in CreatorDetailPage 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #826
Summary
Adds a quorum indicator to each active proposal card so voters can see participation progress against the required threshold without leaving the list view.
Changes
quorumBpsandtotalCirculatingSupplyalongside existing proposal fields.getParticipationPercenthelper:totalVotingWeight / totalCirculatingSupply * 100, clamped to[0, 100]for display safety (raw value still used for the reached/not-reached comparison so a proposal isn't shown as "reached" due to clamping).QuorumProgressBarcomponent:quorumBpsposition (converted to a percentage) shows the required threshold.ProposalCard, rendered only for active proposals (per scope — closed/pending proposals don't show it).Data model notes
quorumBpsis basis points (e.g.2000= 20%); converted to a percentage for both the marker position and the comparison.Testing
getParticipationPercent(zero supply guard, over-100% clamp, typical case).QuorumProgressBar: marker position at a fewquorumBpsvalues, label color/text switches correctly at the exact threshold boundary and just above/below it.Acceptance criteria checklist