fix(installer): remove grep usage for Windows compatibility#67
Open
abbas-rz wants to merge 1 commit intoabus-aikorea:mainfrom
Open
fix(installer): remove grep usage for Windows compatibility#67abbas-rz wants to merge 1 commit intoabus-aikorea:mainfrom
abbas-rz wants to merge 1 commit intoabus-aikorea:mainfrom
Conversation
fix(installer): remove grep usage for Windows compatibility in conda channel add step Replaced the Linux-specific `grep -v 'already exists'` pipe with a direct `conda config --add channels conda-forge` call. Conda already returns success when the channel exists, so filtering is unnecessary and broke the installer on Windows (where grep is unavailable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(installer): remove grep usage for Windows compatibility in conda channel add step
Replaced the Linux-specific
grep -v 'already exists'pipe with a directconda config --add channels conda-forgecall. Conda already returns success when the channel exists, so filtering is unnecessary and broke the installer on Windows (where grep is unavailable).Summary
This PR fixes the Windows compatibility issue in the One-Click Installer.
The installer previously ran:
This fails on Windows because
grepis not available by default. Sinceconda config --adddoes not error out when the channel already exists,the filtering is unnecessary.
Changes
Removed the grep pipe and simplified the command to:
Why This Matters