Add Dockerfile and publish docker image - #4
Conversation
|
I'm late with this review @ziadhany . I will give you feedback shortly |
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
0f94370 to
2048230
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
@ziadhany workflow for publishing docker image is not correct.
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @ziadhany, see some suggestions below.
| uses: docker/metadata-action@c299e40c65443455700f0fdfc63efafe5b349051 # v5.10.0 | ||
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | ||
|
|
There was a problem hiding this comment.
Also, auto generated OCI labels/annotations won’t be able to accurately capture the license, description, and title.
| labels: | | |
| org.opencontainers.image.title=HealthyCode | |
| org.opencontainers.image.description=Client to generate GrimoireLab metrics for Project Health using the software analytics platform GrimoireLab | |
| org.opencontainers.image.licenses=GPL-3.0-only | |
| annotations: | | |
| org.opencontainers.image.title=HealthyCode | |
| org.opencontainers.image.description=Client to generate GrimoireLab metrics for Project Health using the software analytics platform GrimoireLab | |
| org.opencontainers.image.licenses=GPL-3.0-only | |
There was a problem hiding this comment.
The license should be GPL-3.0-or-later, I think. https://github.com/aboutcode-org/healthycode/blob/main/pyproject.toml#L9
There was a problem hiding this comment.
Well, license is ambiguous.
 |
 |
|---|
There was a problem hiding this comment.
I think the license specifies:
either version 3 of the License, or
(at your option) any later version.
https://github.com/aboutcode-org/healthycode/tree/main?tab=GPL-3.0-1-ov-file
Update Docker image description Signed-off-by: ziad hany <ziadhany2016@gmail.com>
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @ziadhany, LGTM!
Just confirm the license once.
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
4 participants
Add Docker support for healthycode and publish the Docker image to the GitHub Container Registry