Skip to content

[Refactor] Remove obsolete cloud account lifecycle listeners - #1353

Open
zoomote[bot] wants to merge 2 commits into
mainfrom
fix/extension-lifecycle-promises-0w723cyfrtfqr
Open

[Refactor] Remove obsolete cloud account lifecycle listeners#1353
zoomote[bot] wants to merge 2 commits into
mainfrom
fix/extension-lifecycle-promises-0w723cyfrtfqr

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Expanded the type-aware @typescript-eslint/no-floating-promises ratchet to extension.ts.
  • Removed obsolete auth-state-changed and user-info listener registration, state refresh, and cleanup left behind after interactive cloud accounts were removed.
  • Retained settings-updated for live organization-policy refreshes as contained fire-and-forget work with failure logging.
  • Kept model-cache initialization non-blocking with explicit failure ownership, removed the now-unused no-explicit-any suppression, and updated focused tests.

Why this change was made

The interactive cloud-account UI was already removed, and initial compatibility/static-token state is read after CloudService initialization. The auth and user-info listeners no longer provided required behavior, while the organization-settings listener remains live for policy changes.

Impact

Extension activation has fewer obsolete account lifecycle hooks. Organization policy changes still refresh visible state, model-cache startup still does not block activation, and future floating promises in extension.ts fail lint.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna
edelauna marked this pull request as ready for review August 23, 2026 12:43
@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 23, 2026
@zoomote

zoomote Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Removed the obsolete auth-state and user-info extension listeners and their cleanup/test scaffolding. The live organization-settings listener remains as contained fire-and-forget work with failure logging; model-cache startup remains non-blocking. The stale no-explicit-any suppression was also removed.

Full lint, type-check, and test suites pass. Pushed in commit c86ffac0c.

@zoomote zoomote Bot changed the title [Fix] Cloud state updates can complete before webview refresh [Refactor] Remove obsolete cloud account lifecycle listeners Aug 23, 2026
@github-actions github-actions Bot added awaiting-review PR changes are ready and waiting for maintainer re-review and removed awaiting-review PR changes are ready and waiting for maintainer re-review labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant