[Refactor] Remove obsolete cloud account lifecycle listeners - #1353
Open
zoomote[bot] wants to merge 2 commits into
Open
[Refactor] Remove obsolete cloud account lifecycle listeners#1353zoomote[bot] wants to merge 2 commits into
zoomote[bot] wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
marked this pull request as ready for review
August 23, 2026 12:43
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 23, 2026 12:43
Contributor
Author
|
Removed the obsolete auth-state and user-info extension listeners and their cleanup/test scaffolding. The live organization-settings listener remains as contained fire-and-forget work with failure logging; model-cache startup remains non-blocking. The stale Full lint, type-check, and test suites pass. Pushed in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@typescript-eslint/no-floating-promisesratchet toextension.ts.auth-state-changedanduser-infolistener registration, state refresh, and cleanup left behind after interactive cloud accounts were removed.settings-updatedfor live organization-policy refreshes as contained fire-and-forget work with failure logging.no-explicit-anysuppression, and updated focused tests.Why this change was made
The interactive cloud-account UI was already removed, and initial compatibility/static-token state is read after CloudService initialization. The auth and user-info listeners no longer provided required behavior, while the organization-settings listener remains live for policy changes.
Impact
Extension activation has fewer obsolete account lifecycle hooks. Organization policy changes still refresh visible state, model-cache startup still does not block activation, and future floating promises in
extension.tsfail lint.