[Fix] Background service failures can surface as unhandled rejections - #1352
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
edelauna
marked this pull request as ready for review
August 23, 2026 04:06
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 23, 2026 04:06
Contributor
Author
|
Addressed both lines from Codecov’s initial report with a threshold-one scanner test that executes the in-loop batch cleanup path. Local coverage confirms the reported lines are now exercised; the full lint, type-check, and test suites pass. Pushed in commit |
edelauna
approved these changes
Aug 23, 2026
edelauna
enabled auto-merge
August 23, 2026 04:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@typescript-eslint/no-floating-promisesratchet toservices/**/*.tsand resolved all six existing findings.finally()chains with success/failure cleanup handlers that cannot create an unobserved rejected promise.queueMicrotaskand added focused startup-rejection and threshold-batch cleanup coverage.Why this change was made
Long-running indexing and MCP watcher setup are intentionally started in the background, but their rejected promises were not owned by a terminal handler. Scanner cleanup also discarded the promise returned by
finally(), which can reject whenever its source rejects.Impact
Background service failures are now logged instead of surfacing as unhandled rejections, batch cleanup still runs on success and failure, and future floating promises in
services/**fail lint. Background execution timing remains unchanged.