Skip to content

[Fix] Terminal startup failures can leave commands unresolved - #1351

Merged
edelauna merged 1 commit into
mainfrom
fix/integrations-promise-failures-0w723cyfrtfqr
Aug 23, 2026
Merged

[Fix] Terminal startup failures can leave commands unresolved#1351
edelauna merged 1 commit into
mainfrom
fix/integrations-promise-failures-0w723cyfrtfqr

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Expanded the type-aware @typescript-eslint/no-floating-promises ratchet to integrations/**/*.ts and resolved all eight existing findings.
  • Routed VS Code and Execa terminal startup rejections through the existing process error event so returned command promises reject instead of hanging.
  • Added a caught async boundary for debounced workspace resets, awaited workspace reinitialization, and kept routine webview updates non-blocking.
  • Added focused terminal and workspace failure-path coverage, while preserving OS-specific terminal test synchronization.

Why this change was made

Terminal process starts returned promises that were not observed, so an unexpected startup rejection could bypass the command promise's existing error channel. Workspace resets also launched reinitialization from a timer without handling rejection.

Impact

Terminal startup failures now reach callers deterministically, workspace reset failures are logged without becoming unhandled rejections, and future floating promises in integrations/** fail lint. Successful execution timing remains unchanged.

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/integrations/workspace/WorkspaceTracker.ts 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@edelauna
edelauna marked this pull request as ready for review August 23, 2026 00:24
@edelauna
edelauna enabled auto-merge August 23, 2026 00:24
@edelauna
edelauna added this pull request to the merge queue Aug 23, 2026
@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 23, 2026
Merged via the queue into main with commit 87077e1 Aug 23, 2026
26 checks passed
@edelauna
edelauna deleted the fix/integrations-promise-failures-0w723cyfrtfqr branch August 23, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants