[Fix] Terminal startup failures can leave commands unresolved - #1351
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
edelauna
approved these changes
Aug 23, 2026
edelauna
marked this pull request as ready for review
August 23, 2026 00:24
edelauna
requested review from
JamesRobert20,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 23, 2026 00:24
edelauna
enabled auto-merge
August 23, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@typescript-eslint/no-floating-promisesratchet tointegrations/**/*.tsand resolved all eight existing findings.Why this change was made
Terminal process starts returned promises that were not observed, so an unexpected startup rejection could bypass the command promise's existing error channel. Workspace resets also launched reinitialization from a timer without handling rejection.
Impact
Terminal startup failures now reach callers deterministically, workspace reset failures are logged without becoming unhandled rejections, and future floating promises in
integrations/**fail lint. Successful execution timing remains unchanged.