[Improve] Keep shared controls legible across IDE themes - #1333
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Addressing the Codecov patch gap by excluding Playwright visual fixtures from the Vitest/JSDOM coverage flag; those fixtures are executed and reported by the dedicated Playwright CT coverage job. |
edelauna
previously approved these changes
Aug 22, 2026
edelauna
force-pushed
the
feature/wcag-contrast-snapshots-157cfn81c2ad4
branch
from
August 22, 2026 01:19
61f84fa to
662a14f
Compare
edelauna
force-pushed
the
feature/wcag-contrast-snapshots-157cfn81c2ad4
branch
from
August 22, 2026 01:37
662a14f to
d122f42
Compare
edelauna
force-pushed
the
feature/wcag-contrast-snapshots-157cfn81c2ad4
branch
from
August 22, 2026 01:58
c90d038 to
46f3510
Compare
edelauna
approved these changes
Aug 22, 2026
edelauna
marked this pull request as ready for review
August 22, 2026 04:20
edelauna
requested review from
JamesRobert20,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 22, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ChatTextAreaandUISettings, including focused chat-composer states and a numeric UI Settings header contrast assertion.themes.tsnow contains only theme IDs, classes, and application orchestration.Why this change was made
Theme-token usage alone does not guarantee sufficient rendered contrast, and copied theme values inevitably drift from the VS Code runtime that injects them. This adds numeric WCAG 2.2 AA gates and makes the pinned VS Code webview itself the source of truth for visual fixtures.
Impact
Shared controls, chat composition, and UI Settings remain identifiable across maintained light, dark, and high-contrast themes. Future VS Code upgrades cannot silently stale the fixture colors: the real-runtime drift job and pinned visual snapshots must both pass before merge.
Related PRs