[Fix] Queued messages no longer approve pending actions - #1318
Draft
zoomote[bot] wants to merge 3 commits into
Draft
[Fix] Queued messages no longer approve pending actions#1318zoomote[bot] wants to merge 3 commits into
zoomote[bot] wants to merge 3 commits into
Conversation
This was referenced Aug 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Queued user input now reaches pending tool, command, MCP, and child-completion prompts as feedback instead of an implicit approval. The existing
command_outputflow-control exception remains non-draining.The change includes focused unit coverage for both queue timing windows and a deterministic VS Code e2e that queues input while a child is completing, verifies the child processes it, and only then allows the parent to resume.
Why this change was made
Queued instructions could previously trigger
yesButtonClicked, causing commands to run or delegated children to complete before processing the user's new direction. This fixes #1308 and establishes the explicit-approval invariant tracked under #355.Impact
Users can safely steer a running task with queued input without bypassing approval controls. Explicit approvals and configured auto-approval continue to behave normally when no queued intervention is present.
Related PRs