Repository navigation
drivers: fix the Hs-mode range in I2C Address.check_reserved - #1099
Merged
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1085
The Hs-mode controller code is
0000 1XX(0x04-0x07), butcheck_reservedreturnedHighSpeedMasterfor 0x08-0x0F, so ordinary addresses such as 0x0C were refused and the real Hs-mode codes were accepted. The test table had the same wrong range, so it now expects 0x04 and 0x07 to be reserved and 0x08 to be valid.