feat(xof): add IXOFStream continuous-squeeze API across all XOFs#79
Merged
Conversation
Core design: - New IXOFStream (public) and IXofReader (internal "engine") interfaces. - Extract the squeeze core of each algorithm family into a self-contained IXofReader engine (TKeccakXofReader, TBlake2XSXofReader, TBlake2XBXofReader; Blake3's reader renamed to TBlake3XofReader). - Each algorithm is now a single class implementing both IXOF and IXOFStream over the shared engine, so DoOutput/Squeeze delegate to one squeeze implementation instead of duplicating it. KMAC fix: - Fix a latent bug where RightEncode(0) was re-appended on every DoOutput for KMAC-XOF, corrupting multi-chunk output. RightEncode is now applied exactly once per Initialize via EnsureRightEncodeAppended. - Fix bit-alignment check typo in TKMAC*XOF.SetXOFSizeInBitsInternal ((LXofSizeInBytes and $7) -> (AXofSizeInBits and $7)). Blake2X streaming: - Unbounded mode is selected via the spec's reserved "unknown length" marker, encapsulated in TBlake2XS.CreateBlake2XSXofStream / TBlake2XB.CreateBlake2XBXofStream so callers never touch the sentinel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core design: