Skip to content

Media: Correct error message for rejected image uploads - #13059

Open
benitoalba wants to merge 1 commit into
WordPress:trunkfrom
benitoalba:64617-media-upload-http-error
Open

Media: Correct error message for rejected image uploads#13059
benitoalba wants to merge 1 commit into
WordPress:trunkfrom
benitoalba:64617-media-upload-http-error

Conversation

@benitoalba

Copy link
Copy Markdown

Summary

Plupload currently maps every image HTTP_ERROR to the image-processing message, including HTTP 4xx responses from hosting security layers. This makes a ModSecurity rejection look like an image-size or 2560-pixel failure.

This change uses the existing generic HTTP error for image uploads rejected with a 4xx response. Image/server failures outside the 4xx range retain the existing image-processing guidance, and non-image behavior is unchanged.

The patch does not alter filename sanitization or attempt to bypass the hosting firewall. A clean Core environment accepts test'image.jpg and stores it as testimage.jpg; the original host-specific ModSecurity rejection is not reproducible locally without intercepting the response.

Trac ticket: https://core.trac.wordpress.org/ticket/64617

Testing

  • npm run test:e2e -- tests/e2e/specs/media-upload.test.js — 4 passed
  • npm run grunt -- jshint:corejs — passed
  • npm run typecheck:js — passed
  • npm run grunt -- qunit:compiled — build completed, then Grunt's Windows npx launcher returned spawn EINVAL
  • Direct underlying QUnit command, npx playwright test --config tests/qunit/playwright.config.js — 2 passed; 566/566 compiled and 566/566 source tests passed

The E2E coverage verifies a clean apostrophe-containing JPEG upload, an intercepted HTTP 403 response using the generic response message without 2560-pixel guidance, and an intercepted HTTP 500 response retaining the image-processing guidance.

Use of AI Tools

AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5.6 Sol, GPT-5.6 Luna
Used for: Planning, implementation, test authoring, local validation, and an independent final patch review.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@benitoalba
benitoalba marked this pull request as ready for review August 15, 2026 03:10
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props benitoalba.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant