Block Supports: Bail early in state styles when a block has no style attribute - #13051
Draft
mukeshpanchal27 wants to merge 1 commit into
Draft
Block Supports: Bail early in state styles when a block has no style attribute#13051mukeshpanchal27 wants to merge 1 commit into
mukeshpanchal27 wants to merge 1 commit into
Conversation
…attribute. `wp_render_block_states_support()` is registered on `render_block`, so it runs once per block on every request. Before determining that a block has no state styles, it performed a block type registry lookup, resolved global settings via `wp_get_global_settings()`, and computed responsive media queries through `WP_Theme_JSON::get_viewport_media_queries()`. Every CSS rule the function can produce is keyed off the block's `style` attribute, and the function already returns the content unchanged when no rules are generated. Bailing out as soon as `style` is absent is therefore behaviour-preserving, and skips that work for the overwhelming majority of blocks, which carry no `style` attribute at all. Measured on trunk with a `core/paragraph` block that has no `style` attribute: 1396.6 ns/block before, 100.4 ns/block after. Output verified byte-identical across styled and unstyled fixtures for `core/button`, `core/navigation-link`, and `core/paragraph`, plus empty-style, no-attrs, and unregistered-block cases. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket:
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.