fix: Prevent world ticking thread hang during ItemEntity#mergeWithNeighbours (#802) - #897
Open
Kameshekf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #802
Summary of the Problem
When
parallel-world-ticking: enabled: trueis active on servers with high-density item drops (such as carpet duper machines, sand duplicators, or high-yield mob farms),ItemEntity#mergeWithNeighbours()causes theLeaf Level Ticking Thread - worldto freeze/deadlock inca.spottedleaf.moonrise.patches.chunk_system.level.entity.ChunkEntitySlices$EntityCollectionBySection.getEntities.The hang occurred due to two main factors:
mergeWithNeighbours()on the exact same tick cycle (this.tickCount % i == 0).getEntitiesOfClass()yields an enormous collection of nearby items, leading to excessive lock contention and CPU starvation across parallel world threads.Solution
(this.tickCount + this.getId()) % i == 0, eliminating synchronized tick spikes.mergedCount >= 32).Testing & Verification
parallel-world-ticking: true.