Repository navigation
window-rules: preserve explicit initial position - #3151
Merged
ammen99 merged 1 commit intoOct 3, 2026
Merged
Conversation
When applying a window rule to a view that generates multiple pre-map transactions, such as Microsoft Edge, the place plugin can override the rule during startup. This affects set geometry and move actions, causing the window to be placed by the place plugin instead of at the position specified by the window rule. Signed-off-by: stephen finkel <mrsteve0924@verizon.net> Assisted-by: ChatGPT:GPT-5.6 Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a window rule to a view that generates multiple pre-map transactions, such as Microsoft Edge, the
placeplugin can run again after the rule has already set the initial position. Sinceon createdrules are only applied once, a subsequent placement pass can overridemoveorset geometry, causing the view to be positioned byplaceinstead of at the coordinates specified by the rule.Mark views moved by
window-rulesbefore mapping with the existingstartup-xandstartup-yproperties. Theplaceplugin already treats these properties as an indication that the initial position has been explicitly specified and skips placement.This preserves explicit
moveandset geometryactions across subsequent pre-map transactions without changing the behavior of views that have not been explicitly positioned.