Skip to content

expo: toggle "disabled_for" option - #3150

Closed
vdegenne wants to merge 1 commit into
WayfireWM:masterfrom
vdegenne:expo-toggle-disabled-for
Closed

vdegenne wants to merge 1 commit into
WayfireWM:masterfrom
vdegenne:expo-toggle-disabled-for

Conversation

@vdegenne

@vdegenne vdegenne commented Oct 1, 2026

Copy link
Copy Markdown

This PR just adds an option to prevent the toggle shortcut to trigger in certain windows.

@ammen99

ammen99 commented Oct 3, 2026

Copy link
Copy Markdown
Member

I feel like this is out of scope for expo, but here is how you can implement this: use IPC :)

Instead of defining a keyboard shortcut in the config file to start expo, bind that key to your script. You can even create the binding from within the script, the command plugin supports that. Once in your script, you can check the focused window against any criteria you want, and optionally call toggle_expo.

@ammen99 ammen99 closed this Oct 3, 2026
@ammen99

ammen99 commented Oct 3, 2026

Copy link
Copy Markdown
Member

Nonetheless, thanks for the PR :) Let me know if you need any help with the IPC approach. If you have opencode or any other agentic AI tool, I am sure they can figure it out if you point them to the pywayfire repo.

@vdegenne

vdegenne commented Oct 3, 2026 •

Copy link
Copy Markdown
Author

Why would I need the IPC approach? I implemented the option in the plugin and it literally works as expected already. The PR was to make other users profit from it if they ever need it, without the need to go through the burden of writing yet another IPC script for it.

@ammen99

ammen99 commented Oct 3, 2026

Copy link
Copy Markdown
Member

Why would I need the IPC approach? I implemented the option in the plugin and it literally works as expected already. The PR was to make other users profit from it if they ever need it, without the need to go through the burden of writing yet another IPC script for it.

I understand that, but consider what would happen if we decided to upstream every little feature or tweak any Wayfire user needed. This particular toggle seems very niche, and given that there are other ways to achieve the same effect, I find it better to not clutter upstream with options.

That being said, I am curious about your use case here - why do you need this option?

@vdegenne

vdegenne commented Oct 3, 2026

Copy link
Copy Markdown
Author

I believe the default is <super>+e so maybe it would be left unnoticeable because apps never use this shortcut. But yet the shortcut is customizable in the plugin and this is where it can conflict with other programs.
Personally I've always used mouse wheel button for this toggle, this is the most natural imo and I rarely use this button for other app functions anyway. However sometimes mouse wheel button is bound to natural mouse motion functions in some apps (blender to name one), in this case you wouldn't want the expo to show when you click it.

The XML could be modified to place the option at the bottom to avoid messing with what was already there if you want.
Either way it's fine, I can live on with the fork.

@soreau

soreau commented Oct 4, 2026

Copy link
Copy Markdown
Member

@vdegenne I use vinagre as a vnc client and it captures input if the mouse is over the window. I know it's a long shot but you might be able to request this feature in blender, especially since it has many custom input actions.

@vdegenne
vdegenne deleted the expo-toggle-disabled-for branch October 4, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants