Repository navigation
Bridge: sync authenticate, testLogin and profile to NDI-matlab 3cb19a85f (NDI-matlab#1049) - #342
Merged
Merged
Conversation
VH-Lab/NDI-matlab#1049 made NDI_CLOUD_USERNAME / NDI_CLOUD_PASSWORD pick the account a new login uses, ahead of a MATLAB Vault entry for a different email, so setting them (or switchProfile) actually switches account. authenticate.m changed; testLogin.m and profile.m only in their help text. Python already had that order -- an existing token, then the environment's credentials, then the saved profile -- and switch_profile already took effect the same way, so no code changes: the three entries move to 3cb19a85f with a note saying the two sides now agree. This clears their drift in test_matlab_bridge_hashes. Still drifted, and left for a separate port: export.all_binary, export.autoMultiplier and export.oneProbe, moved by VH-Lab/NDI-matlab#1050. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KChjwyZT9314dmEuS5ovUP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VH-Lab/NDI-matlab#1049 made
NDI_CLOUD_USERNAME/NDI_CLOUD_PASSWORDchoose the account a new login uses, ahead of a MATLAB Vault entry for a different email. Setting them, or callingswitchProfile, now actually switches account. In MATLAB,authenticate.mchanged in code, andtestLogin.mandprofile.mchanged only in their help text.Python already had that order: an existing token, then the environment's credentials, then the saved profile.
switch_profilealready took effect the same way. So no code changes: the three bridge entries move to3cb19a85f, each with a note that the two languages now agree. This clears their drift intest_matlab_bridge_hashes.Still drifted, and not in this PR
export.all_binary,export.autoMultiplierandexport.oneProbe(src/ndi/fun/probe) were changed by VH-Lab/NDI-matlab#1050:autoMultipliernow treats whole-number doubles as raw counts;all_binarychooses the multiplier per probe;jrclust.mexporter.Those need a real port, so
test_matlab_bridge_hashesstays red on those three until a follow-up lands.Validation
mainat3cb19a85f: 198 passed, 1 failed. The failure is the probe-export drift above; the three entries changed here are no longer flagged.Generated by Claude Code