Retire the manifest cloud-reference workaround (companion to VH-Lab/NDI-matlab#986) #300

Companion to VH-Lab/NDI-matlab#986. Ports the workaround retirement now that VH-Lab/DID-python#88 has landed the reads that make it unnecessary.

What the workaround is

ndi.cloud.filehandler.updateFileInfoForLocalFiles rewrites a downloaded document's file_info to point at the local files that came down with it. For a series MANIFEST it did two things a plain file does not:

1. Set the local file location (same as any file).
2. Append a second ndicloud location ndic://<cloudDatasetId>/<manifestUid> alongside.

The second location was there to give DID's custom_file_handler a non-file source path for member fetches. Without it, download_file_from_cloud was handed a plain local path and returned without producing anything, so every member of a downloaded series read as absent -- silently, because DID reads a handler that fails as a plain miss. See VH-Lab/NDI-matlab#966.

Why it can go now

• Offer a local-file manifest to the handler too (unblocks #188 for its main caller) VH-Lab/DID-matlab#191 taught the read path to reach a local-file manifest directly (a manifest whose only location is a local file is offered to the handler, and the guard against a handler that returns the manifest's own bytes makes that harmless).
• localSeriesManifestPath cannot fetch a remote manifest — series reads fail on cloud-only downloads VH-Lab/DID-matlab#201 closed the last case: a cloud-only manifest fetched through the same handler.
• Both landed. Both were ported to Fetch a remote-only series manifest through the custom_file_handler (#87) VH-Lab/DID-python#88 (merged).

That makes the second location dead weight -- DID never consults it anymore.

What to change

src/ndi/cloud/filehandler.py:

• In updateFileInfoForLocalFiles, drop the block that appends _ndic_location_record(cloud_dataset_id, uid) to a manifest's locations. Simplify the write-back around it (no more grown-list case).
• Remove the now-unused helpers _ndic_location_record and _declared_series_names.
• Update the docstring: cloud_dataset_id still drives the ingest_locations rebuild via reconstructSeriesIngestLocations (Cloud-downloaded documents refused by DID's MembersNotLocatable guard VH-Lab/NDI-matlab#958), but no longer the manifest's second location.
• Comment update at the call site in src/ndi/cloud/orchestration.py.

tests/test_cloud_series_reconstruction.py:

• Remove TestTheManifestKeepsItsCloudReference (analog of TestDownloadedSeriesManifestKeepsItsCloudLocation.m; its whole subject was pinning the second location).
• Remove test_a_member_of_a_downloaded_series_can_be_read -- it asserted the handler receives an ndic:// URI built from the manifest's second location, which no longer exists. End-to-end coverage of a member of a downloaded series lives on the cloud side, mirroring NDI-matlab's testMembersSurviveADownloadFromTheCloud.
• Add TestSeriesManifestHasExactlyOneLocation as the regression guard: exactly one location, of type file. This mirrors TestUpdateFileInfoPreservesSeries.testSeriesManifestHasExactlyOneLocation added in Retire the manifest cloud-reference workaround (#986) VH-Lab/NDI-matlab#989.

Bridge yamls:

• Bump matlab_last_sync_hash on updateFileInfoForLocalFiles to the NDI-matlab#989 head (2ad46c0f) and drop the "second location beside the local copy" language from the decision_log.
• Companion notes in src/ndi/cloud/sync/ndi_matlab_python_bridge.yaml.

Related work, deliberately out of scope

VH-Lab/NDI-matlab#988 also taught the SyncFiles=false path (updateFileInfoForRemoteFiles) to rebuild series ingest_locations by fetching the manifest bytes through the DID customFileHandler contract. NDI-python's updateFileInfoForRemoteFiles does not yet do this -- a document with a populated series returned from a SyncFiles=false cloud round trip will hit DID's MembersNotLocatable guard on the following add_docs. Separate issue, separate change.

References

• Retire the manifest cloud-reference workaround and add an offline SyncFiles=false round-trip test once DID-matlab#201 lands VH-Lab/NDI-matlab#986 (parent, MATLAB side)
• Retire the manifest cloud-reference workaround (#986) VH-Lab/NDI-matlab#989 (the MATLAB retirement PR)
• No test reads a file series MEMBER back out of the cloud: the round trip is only proven for the manifest VH-Lab/NDI-matlab#966 (why the workaround existed)
• Cloud-downloaded documents refused by DID's MembersNotLocatable guard VH-Lab/NDI-matlab#958 (why cloud_dataset_id stays in the signature)
• Offer a local-file manifest to the handler too (unblocks #188 for its main caller) VH-Lab/DID-matlab#191, localSeriesManifestPath cannot fetch a remote manifest — series reads fail on cloud-only downloads VH-Lab/DID-matlab#201 (DID-side changes that make the workaround unnecessary)
• Fetch a remote-only series manifest through the custom_file_handler (#87) VH-Lab/DID-python#88 (DID-python port that closed the loop)