style: show test run attributes as chips in the details dialog - #382
Merged
nGervasyuk merged 2 commits intoJul 27, 2026
Merged
Conversation
OS, device, browser, viewport and custom tags were flat caption text of the same weight as the diff numbers, so picking out one of them - the locale, say - meant reading the whole line. Render them as the same small chips the test run list already uses for these fields, with the field name in a tooltip, and leave the diff numbers as text.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
In the fullscreen approve/reject dialog the metadata line reads:
Every part is the same size and weight, so picking out a single attribute while reviewing screenshot after screenshot means reading the whole line each time. The value you usually want — which variant of the screen this is — is the hardest to spot, because half the line is field names.
The test run list already renders these same five fields (
os,device,browser,viewport,customTags) as small chips in its Tags column, so the dialog was the odd one out.Changes
size="small"chips the list uses, with the field name in a tooltip. The eye is already trained to look for these values as chips one screen earlier.Only
TestRunDetailsis touched.MatchingVariationsDialoghas a similar line; happy to align it in a follow-up if you'd like, but it felt out of scope here.Testing
project-page-test-run-details.pngPlaywright snapshot.tsc --noEmit,eslint,prettierandvite buildclean.Screenshots