fix: scroll the build list back to the top on page change - #381
Merged
nGervasyuk merged 2 commits intoJul 27, 2026
Merged
Conversation
The list keeps its scroll offset when the page changes, so paging from the bottom of one page lands you in the middle of the next one. Reset the scroll container whenever the page is requested. The build mock now serves any take/skip so the test can page through a list longer than one page.
…ll-to-top # Conflicts: # integration_tests/test/projec.spec.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The build list keeps its scroll offset when the page changes. Scroll to the bottom of page 1, click 2, and you land in the middle of the next page and have to scroll back up to see its first builds.
The skeletons shown during the fetch don't reset it:
SkeletonListisheight: 100%inside a<List>that has no definite height, so it collapses to its content and the container stays tall enough to keep the offset.Changes
mockGetBuildsnow serves anytake/skipby slicing the given builds and reporting a realtotal, instead of matching onlyskip=0and hardcodingtotal: 3. Existing callers pass three builds, so they see the same response as before.Testing
scrollTop === 0.438px.tsc --noEmit,eslint,prettierandvite buildclean on changed files. No snapshot change.Screenshots
Screen.Recording.2026-07-27.at.11.44.04.mov