Fix empty licence column in ListAllAvailableImages (get_instances)#52
Merged
Conversation
get_instances matched the dataset licence edge as [:license|licence], but the canonical relationship in the VFB Neo4j graph is has_license. Most DataSets (e.g. Hemibrain Xu2020NeuronsV1.2.1, FAFB Turner_Evans2020) use has_license, so lic bound null and the REPLACE(..., '[null](null)', '') collapsed the column to an empty string; the British-spelt licence alternate matched nothing. Align with the other two image/dataset queries in this file (get_all_aligned_images, the dataset query) and vfb_connect's TermInfo, all of which use [:has_license|license].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_instances matched the dataset licence edge as [:license|licence], but the canonical relationship in the VFB Neo4j graph is has_license. Most DataSets (e.g. Hemibrain Xu2020NeuronsV1.2.1, FAFB Turner_Evans2020) use has_license, so lic bound null and the
REPLACE(..., 'null', '') collapsed the column to an empty string; the British-spelt licence alternate matched nothing.
Align with the other two image/dataset queries in this file (get_all_aligned_images, the dataset query) and vfb_connect's TermInfo, all of which use [:has_license|license].