Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A lowercase Windows drive letter in
baseIniRootscaused the scanner to storebig:///c:/...while definition navigation looked upbig:///C:/.... The archive was indexed, but Go to Definition returned no location.Share URI normalization between scanning and client requests so definitions and archived source text use the same keys.
Bump the cache producer version so older records rebuild automatically.
Add regressions for navigation into and within archived INI files, including a server restart that confirms the saved cache is reused, VS Code URI encoding, and exact definition ranges.
Closes [Feature] Goto definition for cached files #66.
Tests
Passed locally on Windows:
cargo test --lockedcargo test --locked -p zerosyntax-server big_uri_normalizes_configured_drive_lettercrates/server/tests/e2e.pycrates/server/tests/e2e_big_cache.pycargo clippy --locked --all-targets --all-features -- -D warningscargo fmt --all --checkgit diff --checkChecklist