Skip to content

Suggest object overrides in map files - #115

Merged
ViTeXFTW merged 2 commits into
devfrom
t3code/allow-new-object-names
Sep 8, 2026
Merged

ViTeXFTW merged 2 commits into
devfrom
t3code/allow-new-object-names

Conversation

@ViTeXFTW

@ViTeXFTW ViTeXFTW commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

  1. Suggest indexed objects while completing top-level Object names in map.ini and solo.ini
  2. Keep new object names valid by treating this as completion-only
  3. Add regression coverage for blank and partial Object headers

Tests

  • cargo test -p zerosyntax-analysis

@greptile-apps

greptile-apps Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Greptile Summary

This PR adds indexed base-object suggestions when completing top-level Object headers in map.ini and solo.ini while preserving support for new object names.

  • Introduces a dedicated completion context for Object headers in override-layer files.
  • Filters suggestions to objects with at least one non-override definition.
  • Adds regression coverage for blank and partial headers and override-only objects.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/analysis/src/completion.rs Adds map/solo Object-name completion and regression tests; the previously reported override-only suggestion issue is now addressed.
crates/analysis/src/index.rs Adds filtering that exposes only Object names backed by at least one non-override definition.

Reviews (2): Last reviewed commit: "fix: exclude map-only object completion ..." | Re-trigger Greptile

Comment thread crates/analysis/src/completion.rs
@ViTeXFTW

ViTeXFTW commented Sep 8, 2026

Copy link
Copy Markdown
Owner Author

@greptile review

@ViTeXFTW
ViTeXFTW merged commit 11cb80a into dev Sep 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Show existing objects in map.ini

1 participant