Suggest object overrides in map files - #115
Merged
Merged
Conversation
|
| Filename | Overview |
|---|---|
| crates/analysis/src/completion.rs | Adds map/solo Object-name completion and regression tests; the previously reported override-only suggestion issue is now addressed. |
| crates/analysis/src/index.rs | Adds filtering that exposes only Object names backed by at least one non-override definition. |
Reviews (2): Last reviewed commit: "fix: exclude map-only object completion ..." | Re-trigger Greptile
Owner
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests