[Rust] Fix off-by-one accesses to operand lists within MediumLevelILInstruction::lift#8156
Merged
Conversation
Member
|
This is apoved. The fix aligns with the python and C++ usage. |
plafosse
approved these changes
May 7, 2026
…nstruction::lift This could result in a crash or incorrect data being read. Fixes #8155
bdash
force-pushed
the
test_rust_mlil_operands
branch
from
2e6f7c3 to
82f6cd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could result in a crash or incorrect data being read.
Fixes #8155.
The crash report in #8155 was due to the
MemPhicase. I found theMemoryIntrinsicSsacase while reviewing the other instructions that have operand lists.