Repository navigation
Use ty's None-union truthiness rule - #1657
Open
adamtheturtle wants to merge 1 commit into
Open
adamtheturtle wants to merge 1 commit into
adamtheturtle wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ty from 0.0.84 to 0.0.85, the first release containing astral-sh/ruff#28889. The existing
rules.all = "error"setting enablestruthiness-test-of-none-union, so truthiness checks that conflateNonewith other falsy values are now rejected.Validation: project-wide
ty check,pyproject-fmt --check, andgit diff --checkpassed. A temporaryint | Noneexample confirmed that the project configuration emits the new diagnostic. The existing ty documentation-example command also passed. No source changes or rule suppressions were needed.