Repository navigation
Keep request timeout policy in the backend adapter - #3765
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared prepared requests currently turn timeouts into skips when the URL starts with a canonical Vuforia host. A consumer using that URL therefore inherits real-service policy, while the real adapter using a custom URL does not.
Add a typed, scoped timeout handler. The request sender uses a small context manager which propagates the original timeout by default. The real VWS and Model Target adapters install the existing skip behavior for their setup context. Nested contexts restore the previous handler, including when a handler raises. This removes the timeout branch's coverage exemption.
The new tests raise timeouts directly inside the same context used by the sender. They do not replace request methods, credential readers, or cleanup functions. The public real Model Target setup fixture verifies skip-policy installation and removal without account access or network calls.
Part of #3738 and #3737. Follows merged #3764; this does not complete the remaining shared-suite extraction work.
Validation:
Docker and live-service validation remain with hosted CI.