Repository navigation
Supply shared client URLs through backend fixtures - #3745
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared VWS and query clients currently use the SDKs' default service URLs. Supply
base_vws_urlandbase_vwq_urlthrough backend fixtures and pass them to all four shared clients, including clients for inactive projects. This lets a consuming backend provide the addresses of its running services.This two-file follow-up to #3744 advances #3738, part of #3737. Further URL and backend decoupling remains in #3738.
Validation:
MockVWSconfigured with those custom URLs. All six changed/added fixture bodies are covered across the targeted runs.git diff --checkpasses.Full-suite coverage and real-Vuforia validation remain for hosted CI.